Trim spaces/tabs from serial number [minor]

[Bzzz]

Hi,
some minor bug: Those SAS disks present spaces/tabs at the end of their serial number, which are preserved when copying the s/n field from the SMART data. They are also present in this surface test dialogue which causes some ugly line breaks or spaces before the closing bracket.
Suggestion: Trim 'em off

hds.png (11.41 KiB) Viewed 2536 times

Side note: HD Sentinel is able to extract a ton of SMART data where other tools, even gsmartmontools or CDI, basically refuse to even acknowledge the drive. Common BR10i/SAS3082E controller in HBA mode (IT firmware) with directly attached drives (no expander), so a pretty simple configuration. Thanks a lot for your ongoing development!

S.M.A.R.T.
------------
Attribute Threshold Value
Write errors corrected with possible delays 0 0
Total write errors 0 0
Total write errors corrected 0 0
Total write errors corrected by algorithm 0 0
Total bytes written 0 37.373.036.730.368
Total uncorrected write errors 0 0
SC02_F005 0 21.812.258
SC02_F008 0 0
SC02_F00B 0 3.554.035.247
Read errors corrected by ECC hardware method 0 60.596.824
Read errors corrected with possible delays 0 157
Total read errors 0 0
Total read errors corrected 0 60.596.981
Total read errors corrected by algorithm 0 60.596.981
Total bytes read 0 19.213.253.669.376
Total uncorrected read errors 0 0
SC03_F005 0 0
SC03_F008 0 0
SC03_F00B 0 207.063.390
Verify errors corrected without substantial delay 0 76.004.960
Verify errors corrected with possible delays 0 9
Total verify errors 0 0
Total verify errors corrected 0 76.004.969
Total verify errors corrected by algorithm 0 76.004.969
Total bytes verified 0 170.785.507.652.608
Total uncorrected verify errors 0 0
Non medium errors 0 12
Temperature 28
Reference temperature 68
Application client parameter data #0: $00000000000000000000..
Self test results log #1: $2000BA98FFFFFFFFFFFF..
Self test results log #2: $2000BA98FFFFFFFFFFFF..
Self test results log #3: $2000BA8CFFFFFFFFFFFF..
Self test results log #4: $00000000000000000000..
Self test results log #5: $00000000000000000000..
Self test results log #6: $00000000000000000000..
Self test results log #7: $00000000000000000000..
Self test results log #8: $00000000000000000000..
Self test results log #9: $00000000000000000000..
Self test results log #10: $0000000000000000000..
Self test results log #11: $0000000000000000000..
Self test results log #12: $0000000000000000000..
Self test results log #13: $0000000000000000000..
Power on time 2.866.099 2.866.099
SC15_0001 $00046E9F51170100081702EF.. $00046E9F51170100081702EF..
SC15_0002 $0004C7E221170300081702EF.. $0004C7E221170300081702EF..
SC15_0003 $00157AC651170160126B01AF.. $00157AC651170160126B01AF..
SC15_0004 $00163802511701307070037A.. $00163802511701307070037A..
SC15_0005 $0016B9E551170100602202F5.. $0016B9E551170100602202F5..
SC15_0006 $0029A8D65117016121850103.. $0029A8D65117016121850103..
SC15_0007 $002B7A24511701611B24023D.. $002B7A24511701611B24023D..
SC15_0008 $002B7A25511702611D000182.. $002B7A25511702611D000182..
SC15_0009 $002B7A25511703611EAF012B.. $002B7A25511703611EAF012B..
SC15_8100 $002B376400016C0000016C00.. $002B376400016C0000016C00..
Protocol specific port log #1: $06000001000000001009..
Protocol specific port log #2: $06000001000100000009..
SC30_0004 110.380.676.284.416
SC30_0010 7,23401355409175347E18
SC30_0014 7,23401135506849794E18
SC30_0016 7,2340135540932608E18
SC30_0032 7,23398386727792684E18
SC30_0042 7,23390690146395572E18
SC30_0043 7,23400585751039863E18
SC30_005B 7,23401135506849792E18
SC30_0075 7,2339178965801439E18
SC30_0117 7,23390690148181664E18
SC31_0001 200832
SC31_0002 200832
SC31_0003 10.000
SC31_0004 49
SC32_1B00 3,15045925475506125E18 3,15045925475506125E18
Blocks sent to initiator 0 1.902.038.324
Blocks received from initiator 0 4.199.806.459
Blocks read from cache and sent to initiator 0 2.971.712.679
I/O commands with size smaller than segment size 0 3.468.352.570
I/O commands with size larger than segment size 0 0
SC38_0000 $000003EC1315002BBBB3119A..
SC38_0001 $000003EC2E1E002BBBB32C21..
Power on time 0 2.866.099
Remaining minutes until next internal test 55
SC3E_0009 $0000003C
SC3E_000E $0000000000000000 $00009C66F3C99D45
Primary defect list count 3.092 3.092
Grown defect list count 1 1

[hdsentinel]

Thanks for the suggestion!

Sorry, but I see no bugs/problems at all: the spaces kept exactly to allow identification of the disk drives correctly and completely.
Hard Disk Sentinel uses the disk model, serial number and firmware version fields to identify the disk drives eg. in its database to show the changing health, temperature and S.M.A.R.T. attributes on the S.M.A.R.T. page.

If it would trim (remove) the spaces, then the result would be that all previously collected status/statistics/logs etc.. will be all lost, just like if you'd connect completely new disk drives. This is why the spaces kept, exactly to maintain functionality and stability.
Maybe they could be removed from THIS message box only, thanks for your attention!
But I do not really think it is problem if the complete serial number (including the spaces) displayed there

Thanks for your kind words! Yes, the goal is exactly to allow identification and display of all hard disk drives, even on special controllers/configurations